Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be checked properly.
Resolves #908 .
It implements 3 user settings to customize the date format, the time format, and the decimal number format (see images below).
Implementation Details
I build a custom CultureInfo, and then, in every single request overwrite CultureInfo.CurrentCulture as soon as possible. By using Middleware.
Middleware Location
Where to place the Middleware? We actually use the
UseRequestLocalization()
middleware to let .NET select the best culture initially. So I thought immediately afterwards would be a good place to place my overwrite middleware. But it turns out I need the User object, soUseAuthentication
has to run first. That's why I placed it directly after that.Caching
Caching is critical. We don't want to read the DB on every request just for the locale. The first idea was to just cache each user's CultureInfo. This alone would work, but there are two Problems:
That's why I decided to use a second cache. This second cache caches the HashSet of the users that actually use custom locales.
The HashSet cache and the user's own CultureInfo cache is cleared when they change their Profile Settings.
Hot Path